-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete geometry.py
module: handling sphere and cylinder
#7
Conversation
This definition of Two imports are not used: The nameing: I think it is better to short the class name to: The return type of this class method. Why is it a string I don't understand what |
Okay, but we need it later.
Again, need them later.
We'll add
Because
I think these interfaces will have multiple ways of constructing in the future, and I am using
Idea is that this block is only visible by |
How about this part? What is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Interface should contain minimal memory state.
…e to refine test cases
…est (Doesn't show passed/failed).
Cylinder and Sphere modules complete, passing all test cases. Documentation attached here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Complete `geometry.py` module: handling sphere and cylinder
Changes
Here, the goal is to refactor geometry modules and complete them.
TODO
wip/geometry
BlenderMeshInterfaceProtocol
. Make a unit-test forbsr.geometry.Sphere
andbsr.geometry.Cylinder
based on the fact that objects of these two classes must conform theBlenderMeshInterfaceProtocol
protocol.Sphere
module, so take a look at the structure.Note
@Rohar10 I finished
Sphere
module as an example. You can take a look and finish type-hintingCylinder
module.How to check
make test
make mypy
make docs